-
Notifications
You must be signed in to change notification settings - Fork 176
Fix istio getting started guide #1673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix istio getting started guide #1673
Conversation
Signed-off-by: Dharaneeshwaran Ravichandran <[email protected]>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dharaneeshvrd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @nirrozenbaum |
Hi @dharaneeshvrd thanks for the PR. Are we certain this is broken? Looking at the docs it seems like everything is WAI and all other GW implementations have the install step lower down in the guide. |
@kfswain Yes currently all GW implementations are having the install step lower down the guide but it seems due to #1381 this recent change, inferencepool helm chart for istio provider requires istio's |
@kfswain yup, this is certain. see issue #1649 which I opened after following the quickstart guide and hit that issue. @dharaneeshvrd I think the current change is not the ideal one. I was thinking about adding a new Sub-Section like additionally, when doing this change please pay attention to numbering, cause in current change that was missing (see screenshot below): |
Ok If I understood correctly, the guide would have following sections. Hope I can continue with the changes described above. |
yeah, that sounds good 👍🏻 |
What type of PR is this?
What this PR does / why we need it:
Fix istio getting started guide by reordering the steps since inference pool helm chart requires istio CRDs to be present before installing the chart due to recent change #1381.
Which issue(s) this PR fixes:
Fixes #1649
Does this PR introduce a user-facing change?: